Potentially incorrect data types in the `schedule` table

Technical
1

My team have surfaced a few potential data type errors in the existing HSDS documentation. @davidraznick may already be all over this in 3.0, but I thought I would document our findings here just in case.

schedule

  • schedule.count has a type of date, but we are assuming this should really be a type of number.
  • bymonthday and byyearday have a type of number, but the descriptions say this is a comma separated list, which would required a type of string.

@bloom @MikeThacker @devin

2

Thanks for this @skyleryoung ,

I’m catching up with David tomorrow so will make sure it’s on the radar.

Dan

3

@skyleryoung This has been added as an issue on our Github project today. Thanks again for flagging.

4

Hi all,

Just noting that we’ve tidied these up in this PR. We’ll have a run through all the types and descriptions as part of the 3.0 upgrade work. Thanks for flagging @skyleryoung

Lewis

5

Awesome, my pleasure :slight_smile: Thanks guys.

1 Like